Fix inequality sign and var name in outside bbox test #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcara
force-pushed
the
fix-outside-calc3
branch
2 times, most recently
from
55a040e to
8dfdab4
Compare
mcara
force-pushed
the
fix-outside-calc3
branch
from
8dfdab4 to
8a28efc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #540 +/- ##
=========================================
Coverage ? 87.58%
=========================================
Files ? 22
Lines ? 3955
Branches ? 0
=========================================
Hits ? 3464
Misses ? 491
Partials ? 0 ☔ View full report in Codecov by Sentry. |
WilliamJamieson
approved these changes
Dec 20, 2024
WilliamJamieson
merged commit 4542b6a
into
spacetelescope:master
23 of 24 checks passed
WilliamJamieson
added a commit
to WilliamJamieson/gwcs
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor fix of the inequality in a test for points outside of the footprint. Also changed a variable name because
rangeis a built-in name.